[PATCH] D33151: ThinLTO: Verify bitcode before lauching the ThinLTOCodeGenerator.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl updated this revision to Diff 99214.
aprantl added a comment.

> This assumes that there exists a main module, which is a foreign concept to ThinLTOCodegenerator till now AFAIK. I'm not sure what you're trying to express here?
>  Especially, this seems used only in the `codegen`, which is only use in a very specific mode (i.e. split model where you store optimized bitcode and reprocess to perform only the codegen). In such case either you want to verify all the modules that you're about to codegen or none. I have the impression that you'll check only the first one. Not sure if I missed something.

In the attached version I removed the flag. This will cause the

> void ThinLTOCodeGenerator::run() // CodeGenOnly=true

path to verify the module twice. I'm not particularly concerned by this though and it keeps the code simpler.

I also implemented the suggestion to verify in FunctionImporter.

Thanks!


https://reviews.llvm.org/D33151

Files:
  include/llvm/Transforms/IPO/FunctionImport.h
  lib/LTO/ThinLTOCodeGenerator.cpp
  lib/Transforms/IPO/FunctionImport.cpp
  test/LTO/X86/Inputs/strip-debug-info-bar.ll
  test/LTO/X86/Inputs/strip-debug-info.bc
  test/LTO/X86/strip-debug-info.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33151.99214.patch
Type: text/x-patch
Size: 9009 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170516/dc8adcad/attachment.bin>