[PATCH] D33155: [DWARFv5] Support FORM_strp in the line table header

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 15:08:20 PDT 2017


probinson marked an inline comment as done.
probinson added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFFormValue.h:77-85
+  /// Extracts a value in \p Data at offset from \p OffsetPtr.
   ///
   /// The passed DWARFUnit is allowed to be nullptr, in which
   /// case no relocation processing will be performed and some
   /// kind of forms that depend on Unit information are disallowed.
+  /// \param Data The DataExtractor to use.
+  /// \param OffsetPtr The offset within DataExtractor where the data starts.
----------------
dblaikie wrote:
> Feel free to commit changes like this separately, without pre-commit review. Keeps patches small/targeted/easier to review/revert, etc.
r303214.


https://reviews.llvm.org/D33155





More information about the llvm-commits mailing list