[PATCH] D33251: [lld][ELF]Add option to make .dynamic read only

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 14:49:22 PDT 2017


pcc added a comment.

In https://reviews.llvm.org/D33251#756693, @emaste wrote:

> > Does it make sense to make it read-only from beginning?
>
> For me I think having `.dynamic` relro is sufficient, and might actually like to have MIPS use the conventional DT_DEBUG scheme.


Agreed. It seems that this scheme exists only for historical reasons: looking through binutils history, DT_MIPS_RLD_MAP was introduced in 1994 [0], while PT_GNU_RELRO was introduced 10 years later [1].

[0] https://github.com/bminor/binutils-gdb/commit/4c040a649b610ab1a0b5aa30c01148bffa9e2f4b
[1] https://github.com/bminor/binutils-gdb/commit/8c37241be3b1baf394090269b4b67babceb83d61


Repository:
  rL LLVM

https://reviews.llvm.org/D33251





More information about the llvm-commits mailing list