[PATCH] D33257: [JumpThreading] Dont RAUW condition if guards in block
Anna Thomas via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 16 14:10:48 PDT 2017
anna added inline comments.
================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:258
+/// try to replace all uses of Cond with `Val` and erase `Cond`.
+/// We can safely erase Cond only if there are no guards as uses of `Cond`
+/// in the basic block where `Cond` is defined. This is to avoid circular logic
----------------
This should be "We can safely RAUW Cond only if ...".
I have separated this out into a function because there are 2 places currently where we try to RAUW the condition. Tests added trigger both these source code cases: `ProcessBlock` and `ProcessThreadableEdges`.
https://reviews.llvm.org/D33257
More information about the llvm-commits
mailing list