[PATCH] D33245: Simplify the use of CVTypeVisitor

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

Having just figured out some of this pipeline stuff, I really appreciate making this easier to user.



================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CVTypeVisitor.h:51
+Error visitTypeRecord(CVType &Record, TypeIndex Index,
+                      TypeVisitorCallbacks &Callbacks, bool Deserialize = true,
+                      TypeServerHandler *TS = nullptr);
----------------
I'm not a big fan of bool params, because it can be harder for people reading the call sites to know what they mean.  How about making the Deserialize parameter an enum?


https://reviews.llvm.org/D33245