[PATCH] D33229: [BinaryStream] Simplify the process of using BinaryStreams

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 13:28:00 PDT 2017


zturner added a comment.

In https://reviews.llvm.org/D33229#756559, @rnk wrote:

> This makes things shorter, but it does it by using templates to forward constructor arguments. Do we really want to do that? Is there some way we can simplify this code by removing some of the overlapping stream concepts instead?


I could get rid of the forwarding constructor by just providing a couple of explicit overloads.


https://reviews.llvm.org/D33229





More information about the llvm-commits mailing list