[PATCH] D32252: [GVN] Add phi-translate for scalarpre as a temporary solution

Wei Mi via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 12:39:28 PDT 2017


On Mon, May 15, 2017 at 10:04 AM, Davide Italiano via Phabricator
<reviews at reviews.llvm.org> wrote:
> davide added a comment.
>
> In https://reviews.llvm.org/D32252#750282, @wmi wrote:
>
>> I change the DenseMap numberingExpression (mapping from value numbering to GVN::Expression) to std::vector. Although there is still some minor increase but better than before.
>>
>> 400.perlbench 0.81%
>>  401.bzip2    -0.11%
>>  403.gcc      -0.42%
>>  429.mcf      1.58%
>>  433.milc     -0.33%
>>  445.gobmk    0.85%
>>  456.hmmer    0.07%
>>  458.sjeng    -0.42%
>>  462.libquantum       -0.75%
>>  464.h264ref  -1.24%
>>  470.lbm      -0.65%
>>  482.sphinx3  0.44%
>>  998.specrand 0.00%
>>  999.specrand -1.74%
>>  444.namd     0.28%
>>  447.dealII   1.56%
>>  450.soplex   0.96%
>>  453.povray   -0.02%
>>  471.omnetpp  0.02%
>>  473.astar    0.18%
>>  483.xalancbmk        0.85%
>
>
> The compile time numbers don't look particularly bad. Thanks.
> Can you try on large testcases/LTO (maybe of clang itself) to confirm that scales in a sane way?

I bootstrapped clang. The compile time (make -j6, user time) "without
vs with" the patch is: 12464.65 vs 12483.85.
I am now doing the LTO bootstrap now.

>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D32252
>
>
>


More information about the llvm-commits mailing list