[PATCH] D30633: [BPI] Reduce the probability of unreachable edge to minimal value greater than 0

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In https://reviews.llvm.org/D30633#756347, @chandlerc wrote:

> In https://reviews.llvm.org/D30633#756320, @dexonsmith wrote:
>
> > As an aside, it seems the logic around unreachable (with and without the patch) might pessimize code paths that lead to `noreturn` functions, such as `posix_spawn()`.  Is that really what we want?  Why?
>
>
> Heh, I thought about bringing this up, but it really seems orthogonal and something I wanted to look at.
>
> Yeah, generally, the unreachable logic I wrote eons ago was dead wrong and this is still wrong in the case of nice "run forever" functions. I'll either send a patch or file a bug about this.


I agree, no reason to hold the patch up.


https://reviews.llvm.org/D30633