[PATCH] D30081: [PPC] Eliminate more compare instructions using record-form operation
Nemanja Ivanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 16 10:42:57 PDT 2017
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM with the minor nit about the comment addressed on the commit.
================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:1674
+ if (Immed == -1 && Pred == PPC::PRED_GT) {
+ // "greater than -1" means "greater than or equal to 0"
+ // since we are assuming signed comparison by !equalityOnly
----------------
Complete sentences with capitalization, punctuation, etc. in the comments please.
https://reviews.llvm.org/D30081
More information about the llvm-commits
mailing list