[PATCH] D33242: [InstCombine] add motivational comment for tests; NFC

[Sanjay Patel via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL303185: [InstCombine] add motivational comment for tests; NFC (authored by spatel).

Changed prior to commit:
  https://reviews.llvm.org/D33242?vs=99146&id=99161#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D33242

Files:
  llvm/trunk/test/Transforms/InstCombine/logical-select.ll


Index: llvm/trunk/test/Transforms/InstCombine/logical-select.ll
===================================================================
--- llvm/trunk/test/Transforms/InstCombine/logical-select.ll
+++ llvm/trunk/test/Transforms/InstCombine/logical-select.ll
@@ -62,6 +62,11 @@
   ret i32 %t3
 }
 
+; TODO: For the next 4 tests, are there potential canonicalizations and/or folds for these
+; in InstCombine? Independent of that, tests like this that may not show any transforms 
+; still have value because they can help identify conflicting canonicalization rules that 
+; lead to infinite looping. 
+
 ; PR32791 - https://bugs.llvm.org//show_bug.cgi?id=32791
 ; Fold two selects with inverted predicates and zero operands.
 define i32 @fold_inverted_icmp_preds(i32 %a, i32 %b, i32 %c, i32 %d) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33242.99161.patch
Type: text/x-patch
Size: 793 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170516/e60e4971/attachment.bin>