[PATCH] D33212: AMDGPU/GlobalISel: Mark 32-bit float constants as legal
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 16 06:59:43 PDT 2017
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:2118-2120
+
+ if (SIInstrInfo::isGenericOpcode(MI.getOpcode()))
+ return true;
----------------
tstellar wrote:
> arsenm wrote:
> > Why is this necessary? It looks like a separate change
> The verifier rejects G_FCONSTANT instructions, because they have FPImm operands.
Does the base verifier do anything for these? This should call the base implementation
https://reviews.llvm.org/D33212
More information about the llvm-commits
mailing list