[PATCH] D33096: [GlobalISel][X86] Support add i64 in IA32.
Igor Breger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 16 02:56:03 PDT 2017
igorb added inline comments.
================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:590
+
+ // find CarryIn def instruction.
+ MachineInstr *Def = MRI.getVRegDef(CarryInReg);
----------------
guyblank wrote:
> I think you should assert/check that the defining instruction is a COPY from eflags.
I can't check this. The carryIn def instruction is still G_* instruction ( EFLAG copy doesn't created yet ), so i check if it is G_CONST or another G_UADDE instruction.
https://reviews.llvm.org/D33096
More information about the llvm-commits
mailing list