[PATCH] D33124: [ELF] - Detemplate GnuHashTableSection and SymbolTableSection sections.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

Okay, it is not at least as concerning as I first thought. LGTM.



================
Comment at: ELF/SyntheticSections.h:413
   void postThunkContents() override;
-  void writeTo(uint8_t *Buf) override;
-  size_t getSize() const override { return getNumSymbols() * sizeof(Elf_Sym); }
+  size_t getSize() const override { return getNumSymbols() * this->Entsize; }
   void addSymbol(SymbolBody *Body);
----------------
Do you need `this->`?


https://reviews.llvm.org/D33124