[PATCH] D33169: [X86] Adding vpopcntd and vpopcntq instructions

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86InstrAVX512.td:8693
+  Predicate prd> {
+  let Predicates = [prd, NoVLX] in{
+    def Z256_Alt : Pat<(_.info256.VT(OpNode _.info256.RC:$src1)),
----------------
The doc you reference doesn't refer to VLX versions of VPOPCNT - just zmm versions. So shouldn't the NoVLX predicate be dropped?


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:496
 
   static const X86MemoryFoldTableEntry MemoryFoldTable1[] = {
+      {X86::BSF16rr, X86::BSF16rm, 0},
----------------
Please revert these whitespace changes.


Repository:
  rL LLVM

https://reviews.llvm.org/D33169