[PATCH] D32970: [InstCombine] restrict icmp fold with 2 sdiv exact operands (PR32949)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 10:51:10 PDT 2017


spatel added a comment.

In https://reviews.llvm.org/D32970#755263, @davide wrote:

> This is the same as the other no? If so, LGTM.


Yep - the logic is unfortunately duplicated in InstCombine and InstSimplify, so we need 2 patches to solve the bug completely. Since this is a miscompile, I thought it was better to get the fixes in and then think about refactoring to eliminate that duplication.


https://reviews.llvm.org/D32970





More information about the llvm-commits mailing list