[PATCH] D32151: Last of the major pieces to NewGVN - yay!

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

LGTM. I think we can iterate on this in tree. Thank you so much for this piece of work!



================
Comment at: lib/Analysis/BasicAliasAnalysis.cpp:686-688
+    if (!inst->getParent())
+      return nullptr;
     return inst->getParent()->getParent();
----------------
This is unrelated (but you already anticipated).


================
Comment at: lib/Transforms/Scalar/NewGVN.cpp:2395-2397
+NewGVN::makePossiblePhiOfOps(Instruction *I, bool HasBackedge,
+                             SmallPtrSetImpl<Value *> &Visited) {
+  if (!okayForPHIOfOps(I))
----------------
I starred at this very closely and I think it's correct.


https://reviews.llvm.org/D32151