[PATCH] D33187: [ELF] - Use to_integer instead of getAsInteger().

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 04:32:57 PDT 2017


grimar created this revision.

llvm::to_integer appeared in r303011.
I suggest to use to_integer everywhere in LLD instead getAsInteger() because
API of latter is confusing. It returns true on error and false otherwise what makes
reading the code incomfortable.


https://reviews.llvm.org/D33187

Files:
  ELF/Driver.cpp
  ELF/ScriptParser.cpp
  ELF/Strings.cpp
  ELF/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33187.98980.patch
Type: text/x-patch
Size: 3381 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170515/6aaa3bcc/attachment.bin>


More information about the llvm-commits mailing list