[PATCH] D33175: ELF: --gdb-index: Do not add dead sections to the address area.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 02:32:21 PDT 2017


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: lld/test/ELF/Inputs/gdb-index-gc-sections.o.sh:4
+echo "void _start() {} void dead() {}" | \
+clang -Os -g -c -ffunction-sections -o gdb-index-gc-sections.o -x c - -Xclang -fdebug-compilation-dir -Xclang .
----------------
Please add comment about which clang version was used.
Also do you really need -fdebug-compilation-dir ?


https://reviews.llvm.org/D33175





More information about the llvm-commits mailing list