[PATCH] D33124: [ELF] - Detemplate GnuHashTableSection and SymbolTableSection sections.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 01:17:17 PDT 2017


>The wins of being able to remove needles templates far exceeds the cost of and extra class IMHO.

>
>The write method is the only thing that needs ELFT, so the class is just syntax for holding a function pointer.
>
>I am definitely up for suggestions on how to remove these templates some other way, but keeping all this just because of write doesn't look like a good idea.
>
>Cheers,
>Rafael

+1. Total benefit from futher cleanup this allows probably more sensible than a lose from little class that was added.

George.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170515/21892a87/attachment.html>


More information about the llvm-commits mailing list