[PATCH] D33150: [CodeGenPrep]Forming branch from select aggressively in loop

[James Molloy via Phabricator via llvm-commits]

jmolloy added a comment.

Hi Jun,

This feels a bit fishy to me. In particular, you don't ever check if the select is actually on the critical path, unlike your comment. For example:

  %1 = load %a
  %2 = select %1, %3
  store %2

This would be turned into a branch based on your patch, but isn't on the critical path.


https://reviews.llvm.org/D33150