[PATCH] D33142: [Polly][Simplify] Remove writes that are overwritten.

[Tobias Grosser via Phabricator via llvm-commits]

grosser accepted this revision.
grosser added a comment.
This revision is now accepted and ready to land.

L:GTM



================
Comment at: lib/Transform/Simplify.cpp:87
+///   - In block statements, the accesses are in order in which their
+///   instructions are executed. - In region statements, that order of execution
+///   is not predictable at compile-time.
----------------
Formatting is broken.


================
Comment at: lib/Transform/Simplify.cpp:269
+  ///
+  /// Ther must be no read of the same value between the write (that is to be
+  /// removed) and the overwrite.
----------------
There


================
Comment at: lib/Transform/Simplify.cpp:282
+      // Iterate in reverse order, so the overwrites comes before the write that
+      // is to be removed.
+      for (auto *MA : reverse(Accesses)) {
----------------
overwrite


================
Comment at: lib/Transform/Simplify.cpp:285
+
+        // In region statement, the explicit accesses can be in blocks that are
+        // can be executed in any order. We therefore process only the implicit
----------------
"a region statement" or "region statements"


https://reviews.llvm.org/D33142