[PATCH] D33157: [Inliner] Do not mix callsite and callee hotness based updates.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 22:54:26 PDT 2017


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

It would be good in the patch description to maybe clarify the intent / motivation here? I assume the goal is to simplify reasoning about which thresholds are triggered in which cases when the new PM is available? At least, that is my guess based on our in-person conversations.

Anyways, feel free to submit, just seems good to provide context to others reading.



================
Comment at: test/Transforms/Inline/inline-hot-callsite.ll:2
+; This tests that a hot callsite gets the (higher) inlinehint-threshold even
+; without ; without inline hints and gets inlined because the cost is less than
+; inlinehint-threshold. A cold callee with identical body does not get inlined
----------------
`; without ; without` -> `; without`


https://reviews.llvm.org/D33157





More information about the llvm-commits mailing list