[PATCH] D33162: IR: Give function GlobalValue::getRealLinkageName() a less misleading name: getPGOName().

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 20:43:13 PDT 2017


mehdi_amini added a comment.

Most of the uses reads quite wrong since it has nothing to do with PGO. I'm not fond of this renaming right now, can we find another alternative name?



================
Comment at: llvm/include/llvm/IR/GlobalValue.h:446
   /// usual symbol prefix before the symbol name is used then return linkage
   /// name after skipping this special LLVM prefix.
+  ///
----------------
Is this still up to date? How does it play with the `getPGOName` name and the rest of the comment?


https://reviews.llvm.org/D33162





More information about the llvm-commits mailing list