[PATCH] D31724: [SelectionDAG] Remove special call to LHS computeKnownBits for ANDs with constant RHS.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 14:09:08 PDT 2017


spatel added a comment.

In https://reviews.llvm.org/D31724#751377, @craig.topper wrote:

> Correction, the combine-and problem seems to be because SimplifyDemandedBits only considers scalar constants for shift amount, not constant splats from a build_vector.


This is an efficiency improvement, but shouldn't we fix that first to avoid the regression?


https://reviews.llvm.org/D31724





More information about the llvm-commits mailing list