[PATCH] D32241: Don't process debug intrinsics in InstCombine

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 12:36:40 PDT 2017


davide added a comment.

What do you mean with "consistency" of IR? 
This test is checking that we skip llvm.dbg.* instructions, and that's the only thing it should test.
Your test still contains a large amount of unneeded stuffs, which makes it very hard to maintain and to look for somebody else in the future.
Among others, `lifetime.start/end` are largely unneeded.
If there's a good reason to keep all this boilerplate around, please elaborate.


https://reviews.llvm.org/D32241





More information about the llvm-commits mailing list