[PATCH] D33124: [ELF] - Detemplate GnuHashTableSection and SymbolTableSection sections.

[Rafael Avila de Espindola via llvm-commits]

The wins of being able to remove needles templates far exceeds the cost of and extra class IMHO.

The write method is the only thing that needs ELFT, so the class is just syntax for holding a function pointer.

I am definitely up for suggestions on how to remove these templates some other way, but keeping all this just because of write doesn't look like a good idea.

Cheers,
Rafael

On May 12, 2017 2:07:46 PM EDT, Rui Ueyama via Phabricator <reviews at reviews.llvm.org> wrote:
>ruiu added a comment.
>
>I'm not in favor of this change. I don't want to introduce a new class
>in general unless it is worthwhile. It seems this patch introduced a
>new class hierarchy too casually.
>
>
>https://reviews.llvm.org/D33124

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170512/1fc98a06/attachment.html>