[PATCH] D33009: [CodeView] Add an amortized O(1) random access type visitor
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 12 11:14:17 PDT 2017
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: llvm/include/llvm/DebugInfo/CodeView/RandomAccessTypeVisitor.h:71
+
+ // Visited records get automatically added to the type database.
+ TypeDatabase Database;
----------------
rnk wrote:
> You should try to use the Doxygen `///` comments when it makes sense here and below. I don't consume the Doxygen, but there are people who do.
Thoughts?
https://reviews.llvm.org/D33009
More information about the llvm-commits
mailing list