[PATCH] D33105: [AMDGPU] Turn register pressure estimation into forward tracker

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 10:52:28 PDT 2017


vpykhtin added inline comments.


================
Comment at: lib/Target/AMDGPU/GCNRegPressure.cpp:359
+
+  MaxPressure = max(MaxPressure, CurPressure);
+}
----------------
arsenm wrote:
> vpykhtin wrote:
> > arsenm wrote:
> > > std::max, not sure how this builds for you
> > this is overloaded max for GCNRegPressure
> Probably should name it something else
I thought to choose better name for it as it doesn't compare two pressures and returning larger but instead constructs new pressure using maximum values from both, what would be better name here?


Repository:
  rL LLVM

https://reviews.llvm.org/D33105





More information about the llvm-commits mailing list