[PATCH] D33105: [AMDGPU] Turn register pressure estimation into forward tracker

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/GCNRegPressure.cpp:313-314
+
+  if (MI.isDebugValue())
+    return;
+
----------------
Should this be using something like isTransient (as it is now looks inappropriate) to avoid IMPLICIT_DEF from impacting the pressure estimate?


================
Comment at: lib/Target/AMDGPU/GCNRegPressure.cpp:317
+  SlotIndex SI = LIS.getInstructionIndex(MI).getBaseIndex();
+  assert (SI.isValid());
+
----------------
extra space


================
Comment at: lib/Target/AMDGPU/GCNRegPressure.cpp:359
+
+  MaxPressure = max(MaxPressure, CurPressure);
+}
----------------
std::max, not sure how this builds for you


Repository:
  rL LLVM

https://reviews.llvm.org/D33105