[PATCH] D33125: Introduce isoneof<T0, T1, ...> as an extension of isa<T>
Sanjoy Das via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 12 09:32:55 PDT 2017
sanjoy added a comment.
Overall, I think this is a really good abstraction, but given the scope of the change I'll wait for other stakeholders to chime in.
Right now it looks like `isoneof<C>` won't do the right thing -- we should definitely have it "gracefully degrade" to `isa`.
I won't vote for making `isa` variadic since that would read weird. `isoneof`, OTOH, is very understandable so my suggestion would be to stick with that.
Repository:
rL LLVM
https://reviews.llvm.org/D33125
More information about the llvm-commits
mailing list