[PATCH] D32931: [KnownBits] Add bit counting methods to KnownBits struct and use them where possible

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of minor queries



================
Comment at: include/llvm/Support/KnownBits.h:137
+
+  /// Returns the number of trailing zero bits.
+  unsigned countMinTrailingZeros() const { return Zero.countTrailingOnes(); }
----------------
Maybe something like 'minimum known number' - same for the others below


================
Comment at: include/llvm/Support/KnownBits.h:138
+  /// Returns the number of trailing zero bits.
+  unsigned countMinTrailingZeros() const { return Zero.countTrailingOnes(); }
+
----------------
I'd prefer that these were on separate lines but that's me.


https://reviews.llvm.org/D32931