[PATCH] D33119: [AVR] Migrate to new StructType::get owing to Supress all uses of LLVM_END_WITH_NULL
Leslie Zhai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 12 01:38:11 PDT 2017
xiangzhai created this revision.
Hi LLVM developers,
After https://reviews.llvm.org/D32541
static Constant *get(StructType *T, ...) LLVM_END_WITH_NULL;
has been changed to
template <typename... Csts>
static typename std::enable_if<are_base_of<Constant, Csts...>::value,
Constant *>::type
get(StructType *T, Csts *... Vs) {
SmallVector<Constant *, 8> Values{{Vs...}};
return get(T, Values);
}
so it doesn't need to end with nullptr any more, then I simply removed nullptr to fix the build issue for AVR backend, please review my patch, thanks a lot!
Regards,
Leslie Zhai
Repository:
rL LLVM
https://reviews.llvm.org/D33119
Files:
lib/Target/AVR/AVRISelLowering.cpp
Index: lib/Target/AVR/AVRISelLowering.cpp
===================================================================
--- lib/Target/AVR/AVRISelLowering.cpp
+++ lib/Target/AVR/AVRISelLowering.cpp
@@ -361,7 +361,7 @@
SDValue Callee = DAG.getExternalSymbol(getLibcallName(LC),
getPointerTy(DAG.getDataLayout()));
- Type *RetTy = (Type *)StructType::get(Ty, Ty, nullptr);
+ Type *RetTy = (Type *)StructType::get(Ty, Ty);
SDLoc dl(Op);
TargetLowering::CallLoweringInfo CLI(DAG);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33119.98736.patch
Type: text/x-patch
Size: 524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170512/f85c80a0/attachment.bin>
More information about the llvm-commits
mailing list