[PATCH] D33074: InstCombine: Allow sinking instructions with more uses in the same block.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 11 16:04:04 PDT 2017


chandlerc added a comment.

High level comment: this feels really strange to be in instcombine.

Typically, canonicalization wants things *hoisted* not *sunk*, to make the values available for redundancy elimination.

We have a late LoopSink pass already. Do we just need to generalize it to a full sinking pass? That was discussed as a desirable long-term direction in the review.


https://reviews.llvm.org/D33074





More information about the llvm-commits mailing list