[PATCH] D33076: [PPC] Move the combine "a << (b % (sizeof(a) * 8)) -> (PPCshl a, b)" to the backend. NFC.

Tim Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 11 16:06:43 PDT 2017


timshen added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrAltivec.td:1099
+
+def : Pat<(v2i64 (shl v2i64:$vA, v2i64:$vB)),
+          (v2i64 (VSLD $vA, $vB))>;
----------------
iteratee wrote:
> Minor point, the patterns above are grouped by type and then by PPCxxx vs xxx
> Can you group these the same?
Actually this is consistent - the ordering is (operation, PPC or not, types).


https://reviews.llvm.org/D33076





More information about the llvm-commits mailing list