[PATCH] D32605: Recognize CTLZ builtin
Evgeny Stupachenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 11 16:21:31 PDT 2017
evstupac added inline comments.
================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1304-1307
+ IRBuilder<> Builder(PH->getTerminator());
+ SmallVector<const Value *, 2> Ops =
+ {InitX, ZeroCheck ? Builder.getTrue() : Builder.getFalse()};
+ ArrayRef<const Value *> Args(Ops);
----------------
Actually the arguments are unused now. And we don't need to fill them for TTI->getIntrinsicCost. However to avoid bugs in future it is better to rely on real args and type.
Repository:
rL LLVM
https://reviews.llvm.org/D32605
More information about the llvm-commits
mailing list