[PATCH] D32684: [X86] Adding new LLVM TableGen backend that generates the X86 backend memory folding tables.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: utils/TableGen/X86FoldTablesEmitter.cpp:134
+    if (Inst->TheDef->getName().find(InstStr) != StringRef::npos)
+      return true;
+  }
----------------
Convert to any_of ?


================
Comment at: utils/TableGen/X86FoldTablesEmitter.cpp:142
+    if (Inst->TheDef->getName().find(InstStr) != StringRef::npos)
+      return true;
+  }
----------------
Convert to any_of ?


================
Comment at: utils/TableGen/X86FoldTablesEmitter.cpp:455
+
+    for (unsigned i = 0; i < MemInst->Operands.size(); i++) {
+      Record *MemOpRec = MemInst->Operands[i].Rec;
----------------
```
for (unsigned i = 0, e = MemInst->Operands.size(); i < e; i++) {
```


================
Comment at: utils/TableGen/X86FoldTablesEmitter.cpp:598
+    // operand is a memory operand, add instructions to Table#i.
+    for (unsigned i = RegOutSize; i < RegInstr->Operands.size(); i++) {
+      Record *RegOpRec = RegInstr->Operands[i].Rec;
----------------
```
for (unsigned i = RegOutSize, e = RegInstr->Operands.size(); i < e; i++) {
```


https://reviews.llvm.org/D32684