[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

This looks overall good, a few minor nits.



================
Comment at: tools/lld/COFF/Driver.cpp:458
+
+static Expected<COFFModuleDefinition> mutateModuleDefs(MemoryBufferRef MB) {
+  Expected<COFFModuleDefinition> Def =
----------------
1. You don't need to return an object from this function . Returns nothing (void). Use fatal() if you fail to parse a file inside this function.

2. Make this function take a path instead of a MemoryBufferRef object.

3. Rename this parseModuleDefs. (You are not mutating module definitions.)


Repository:
  rL LLVM

https://reviews.llvm.org/D32689