[PATCH] D31788: [ConstantFolding] Add folding for various math '__<func>_finite' routines generated from -ffast-math

Andy Kaylor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 11 13:15:55 PDT 2017


andrew.w.kaylor added a comment.

A couple of things came up as I was preparing this for commit.  They're pretty straightforward issues, so I'll just fix them in my sandbox before committing.



================
Comment at: lib/Analysis/ConstantFolding.cpp:1446
+    // __FINITE_MATH_ONLY__ enabled.
+    if (Name.size() > 2 && Name[1] == '_')
+      switch (Name[2]) {
----------------
There's a '{' missing at the end of this 'if' line.


================
Comment at: lib/Analysis/ConstantFolding.cpp:1467
+      }
+    }
   }
----------------
This needs an 'else return false'.


https://reviews.llvm.org/D31788





More information about the llvm-commits mailing list