[PATCH] D33056: [NewGVN] When a store becomes the leader, update the memory leader for the class
    Davide Italiano via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu May 11 12:14:43 PDT 2017
    
    
  
davide added a comment.
While looking at something completely unrelated I noticed:
  bool isDead() const {
    // If it's both dead from a value perspective, and dead from a memory
    // perspective, it's really dead.
    return empty() && memory_empty();
  }
shouldn't this also do `&& StoreCount == 0` ?
https://reviews.llvm.org/D33056
    
    
More information about the llvm-commits
mailing list