[PATCH] D29892: ar: add llvm-dlltool support

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lib/CMakeLists.txt:24
 add_subdirectory(Passes)
+add_subdirectory(DlltoolDriver)
 add_subdirectory(LibDriver)
----------------
Just a comment on the location: I'm not sure if we want too many of these tool drivers to live in their own top-level directories under `lib`. If we're planning to add this one and maybe others (cvtres?) we should think about creating a new top-level directory and moving the drivers underneath that directory. My preferred bikeshed colour is: `lib/ToolDrivers/llvm-lib`,  `lib/ToolDrivers/llvm-dlltool`, etc.

If this sounds good I'll go ahead and move `LibDriver`.


Repository:
  rL LLVM

https://reviews.llvm.org/D29892