[PATCH] D33088: [LiveVariables] Switch Kill/Defs sets to be `DenseSet`

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 11 10:11:12 PDT 2017


MatzeB added a comment.

If this turns out to be more common and we would want to address this on a more fundamental level, this is what we could do:

- Finally finish the TwoAddressInstructionPass rewrite; LiveVariables has been deprecated for a long time, we just cannot throw it out because of this one last pass.
- Easier fix: The critical edge splitting appears to be a part of PHIElimination that happens before anything else. If we would pull that out into a separate pass and perform it before computing LiveVariables, then we wouldn't need to go through the trouble of updating LiveVariables.


https://reviews.llvm.org/D33088





More information about the llvm-commits mailing list