[PATCH] D33031: [GlobalISel][TableGen] Fix handling of default operands

[Diana Picus via Phabricator via llvm-commits]

rovka updated this revision to Diff 98623.
rovka edited the summary of this revision.
rovka added a comment.

Removed the first loop and extracted a helper for adding renderers for default ops. I think this makes the body of the loop easier to read.

I've kept pretty much the same error detection as before. I think there might still be pathological cases that could pass by undetected, but I can't produce any with my current TableGen skills.

Anyway, with this and some changes that I committed today we can remove the handwritten code for G_ADD and G_SUB in the ARMInstructionSelector.


https://reviews.llvm.org/D33031

Files:
  test/TableGen/GlobalISelEmitter.td
  utils/TableGen/GlobalISelEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33031.98623.patch
Type: text/x-patch
Size: 8133 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170511/dfc56313/attachment.bin>