[PATCH] D33081: Revert "[SDAG] Relax conditions under stores of loaded values can be merged"

David L. Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 17:04:08 PDT 2017


dlj created this revision.

This reverts commit a7aa63a594edfea5321d289b05e074e41c167312.

The change fails with ASAN enabled:

ERROR: AddressSanitizer: use-after-poison on address ... at ...
READ of size 2 at ... thread T0

  #0 ... in llvm::SDNode::getNumValues() const <snip>/include/llvm/CodeGen/SelectionDAGNodes.h:855:42
  #1 ... in llvm::SDNode::hasAnyUseOfValue(unsigned int) const <snip>/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7270:3
  #2 ... in llvm::SDValue::use_empty() const <snip> include/llvm/CodeGen/SelectionDAGNodes.h:1042:17
  #3 ... in (anonymous namespace)::DAGCombiner::MergeConsecutiveStores(llvm::StoreSDNode*) <snip>/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12944:7


https://reviews.llvm.org/D33081

Files:
  include/llvm/CodeGen/ISDOpcodes.h
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  test/CodeGen/X86/merge_store_duplicated_loads.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33081.98563.patch
Type: text/x-patch
Size: 5343 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170511/1d94a075/attachment.bin>


More information about the llvm-commits mailing list