[PATCH] D33009: [CodeView] Add an amortized O(1) random access type visitor

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeDatabase.cpp:165
+  uint32_t ZI = PriorTo.toArrayIndex();
+  int N = ValidRecords.find_prev(ZI);
+  if (N == -1)
----------------
rnk wrote:
> This is linear, it might scan to the beginning of the BitVector without stopping at the beginning of the range.
I could update `BitVector` to have an overload that stops at a certain point?


https://reviews.llvm.org/D33009