[PATCH] D33056: [NewGVN] When a store becomes the leader, update the memory leader for the class

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

I think setting the memory leader to `nullptr` is not quite right. 
We do it

  if (OldClass->memory_empty()) {
    OldClass->setMemoryLeader(nullptr);

because we think there are no memory members, but this is inconsistent with the fact we have a `StoreInst` as leader and a `StoreCount` == 1.


https://reviews.llvm.org/D33056