[PATCH] D33055: [LoopOptimizer][Fix]PR32859, PR24738

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added a comment.

In https://reviews.llvm.org/D33055#751286, @dtemirbulatov wrote:

> I think in the particular case we are limited here to just one predecessor, there is "LCSSAPhi->getNumIncomingValues() == 1" condition above.


Yeah, i'm not sure why (LCSSA.cpp definitely has code to create LCSSA phis that have multiple incoming values, which surprised me, since normally LCSSA is single-valued phis, but ...)
This whole thing seems like a brutal hack (i'm not sure how it's not breaking LCSSA in some cases if we really allow multi-value phis).
But your change should at least be correct for what it does :)


https://reviews.llvm.org/D33055