[PATCH] D33052: Fix variable names.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 10:30:47 PDT 2017


Huh, I didn't notice that your patch included variable name fixes. If you
don't mind, can you commit variable name fixes in place (without moving the
files) now and upload a new patch to D33024? I don't think name changes
actually need pre-commit code review if you commit it now.

On Wed, May 10, 2017 at 10:26 AM, Zachary Turner via Phabricator <
reviews at reviews.llvm.org> wrote:

> zturner added a comment.
>
> Not sure if this will be necessary.  I already applied these changes as
> part of https://reviews.llvm.org/D33024.  chandlerc@ said it's fine to do
> it in the same patch as the move.  Sorry for forgetting about it earlier
> though.
>
>
> https://reviews.llvm.org/D33052
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170510/e02ddb24/attachment.html>


More information about the llvm-commits mailing list