[lld] r302414 - [ELF] - Set DF_STATIC_TLS flag for i386 target.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 06:45:53 PDT 2017


>But if you check inside handleTlsRelocation there is no ambiguity. If we
>can avoid having to add a check for every architecture that would be an
>improvement.
>
>Cheers,
>Rafael

In the first diff of the patch: https://reviews.llvm.org/D32354?id=96149 I checked the relocations
in handleTlsRelocation() using methods isTlsInitialExecRel/isTlsLocalExecRel that we do not have now, 
but it was very close to what you suggest I believe.

And Rui said that time: "I don't want to bury this code deep inside the relocation processing like this"

George.


More information about the llvm-commits mailing list