[PATCH] D33037: [IfConversion] Keep the CFG updated incrementally in IfConvertTriangle

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 06:22:40 PDT 2017


uabelho added a comment.

I have on purpose not attacked IfConvertSimple, IfConvertForkedDiamond
and IfConvertDiamond to keep the size of the patch down, and I haven't seen any
test case where they actually go wrong, but I think they suffer from similar
problems since they also use RemoveExtraEdges/analyzeBranch to fix the CFG at
the end.

If you think this patch changes IfConversion in the right direction then I think
it would be good idea to try to remove the other uses of RemoveExtraEdges as well
later.


https://reviews.llvm.org/D33037





More information about the llvm-commits mailing list