[PATCH] D32793: [ELF] - Don't segfault when assigning non-calculatable absolute symbol value.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/LinkerScript.h:45
   bool ForceAbsolute;
+  bool CanCalculateAbs = true;
 
----------------
ruiu wrote:
> It failed with a segfault because OutSec is null if no address is assigned. So why do you need a new member variable? It seems you can check if OutSec is null.
Yes, you right.

Do we want to add Location member to ExprValue ? ExprValue::getValue() may use it for producing better error reporting.


https://reviews.llvm.org/D32793